Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfiler] Deprecated intercept_redirects in 4.4#33507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromdorumd:i33467
Sep 16, 2019

Conversation

@dorumd
Copy link
Contributor

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#33467
LicenseMIT
Doc PR-

Deprecatedweb_profiler.intercept_redirects config option in symfony 4.4.

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor comments

@dorumd
Copy link
ContributorAuthor

@fabpot@ro0NL Indeed, good point about deprecating it usingConfiguration tooling. Please check my latest changes.

@dorumd
Copy link
ContributorAuthor

@stof I have split the tests. Can you please review?

@fabpot
Copy link
Member

Thank you@dorumd.

@fabpot
Copy link
Member

@dorumd Can you submit a PR on master (I've just merged 4.4 into master) to remove support for the deprecated code?

lyrixx added a commit to lyrixx/symfony that referenced this pull requestSep 18, 2019
…rects in 4.4 (dorumd)"This reverts commit21a05de, reversingchanges made to24faadc.
lyrixx added a commit to lyrixx/symfony that referenced this pull requestSep 23, 2019
…rects in 4.4 (dorumd)"This reverts commit21a05de, reversingchanges made to24faadc.
fabpot pushed a commit to lyrixx/symfony that referenced this pull requestSep 23, 2019
fabpot added a commit that referenced this pull requestSep 23, 2019
…ept_redirects in 4.4 (dorumd)" (lyrixx)This PR was squashed before being merged into the 4.4 branch (closes#33621).Discussion----------Revert "feature#33507 [WebProfiler] Deprecated intercept_redirects in 4.4 (dorumd)"This reverts commit21a05de, reversingchanges made to24faadc.| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| Deprecations? || Tickets       |Fix#33467| License       | MIT| Doc PR        |Commits-------e767bb1 Revert \"feature#33507 [WebProfiler] Deprecated intercept_redirects in 4.4 (dorumd)\"
nicolas-grekas added a commit that referenced this pull requestSep 24, 2019
* 4.4:  [Security/Http] fix typo in deprecation message  [Security] Deprecate isGranted()/decide() on more than one attribute  Fixed a minor typo in the UPGRADE to 5.0 guide  Various tweaks 3.4  Various tweaks 4.3  [Security] Make stateful firewalls turn responses private only when needed  [PhpUnit] Fix usleep mock return value  Revert \"feature#33507 [WebProfiler] Deprecated intercept_redirects in 4.4 (dorumd)\"  [TwigBundle] typo  [TwigBundle] fix test case  [Lock] use Predis\ClientInterface instead of Predis\Client  Allow Twig 3  Minor tweaks  Fix version typo in deprecation notice  [Form][SubmitType] Add "validate" option  hint to the --parse-tags when parsing tags fails  Make legacy "wrong" RFC2047 encoding apply only to one header
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@stofstofAwaiting requested review from stof

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@dorumd@fabpot@stof@OskarStark@ro0NL@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp