NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] fix empty amqp body returned as false#33481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.3fromTobion:amqp-false-body

Sep 6, 2019

Merged

[Messenger] fix empty amqp body returned as false#33481

nicolas-grekas merged 1 commit intosymfony:4.3fromTobion:amqp-false-body

Sep 6, 2019

Conversation

Copy link

Contributor

Tobion commentedSep 5, 2019•
edited
Loading

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Havingfalse in the body breaks typehints in the serializer and is not consistent with other transports like doctrine. Seephp-amqp/php-amqp#351

[Messenger] fix empty amqp body returned as false

ee5cbe3

carsonbot added Status: Needs Review Messenger Bug labels

Sep 5, 2019

nicolas-grekas added this to the4.3 milestone

Sep 6, 2019

nicolas-grekas approved these changes

Sep 6, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Sep 6, 2019

Copy link

Member

nicolas-grekas commentedSep 6, 2019

Thank you@Tobion.

nicolas-grekas added a commit that referenced this pull request

Sep 6, 2019

bug#33481[Messenger] fix empty amqp body returned as false (Tobion)

d081f16

This PR was merged into the 4.3 branch.Discussion----------[Messenger] fix empty amqp body returned as false| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Having `false` in the body breaks typehints in the serializer and is not consistent with other transports like doctrine. Seephp-amqp/php-amqp#351Commits-------ee5cbe3 [Messenger] fix empty amqp body returned as false

nicolas-grekas merged commitee5cbe3 intosymfony:4.3

Sep 6, 2019