Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[MonologBridge] Add Mailer handler#33456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tests are missing
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@stof done, but not sure why build fails. Looks like unrelated |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Proposing this for the 4.4 milestone so that this doesn't block Mailer as a first-class citizen in 4.4/5.0 |
Any news here? I guess a PR to monolog-bundle would be also needed? |
…nolog (javiereguiluz)This PR was merged into the 4.3 branch.Discussion----------[Monolog] Add a caution note about Symfony Mailer and MonologWe can'tfix#12758 properly until this is fixed insymfony/symfony#33456 but meanwhile we can display a caution message to avoid confusion.Commits-------82119af [Monolog] Add a caution note about Symfony Mailer and Monolog
mmarton commentedJan 6, 2020
Any update here? It's the last reason we are still on swiftmailer. :/ |
Hi@BoShurik, how can I help to get this for 5.1? Thank you, |
@noniagriconomie Hi! Sorry for delay. I'll add changes by the end of the week |
Uh oh!
There was an error while loading.Please reload this page.
Needs a review |
Thank you@BoShurik. |
This PR was merged into the 5.1-dev branch.Discussion----------[MonologBridge] Add Mailer handler| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#33209 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | - <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------5b7393b Add monolog mailer handler
Schyzophrenic commentedJun 10, 2020
As many others, this is the last reason we use SwiftMailer. Is there any chance this will be merged into SF 4.4? |
@Schyzophrenic No, new features are never backported. |
This PR was squashed before being merged into the 3.x-dev branch.Discussion----------Add Symfony Mailer supportAdd support for the new symfony mailer directly on the bundle after the MailerHandle was added to the bridge onsymfony/symfony#33456Also this can makesymfony/symfony-docs#13077 move forwardTests are failing due to incompatible phpunit versions, not sure how to fix this...Commits-------4bea89c Add Symfony Mailer support
…(noniagriconomie, OskarStark)This PR was merged into the 5.1 branch.Discussion----------Document usage of Symfony Mailer for error emailRelated tosymfony/monolog-bundle#354andsymfony/monolog-bundle#354 (comment)----------Should we also document that for the `v4.4` of this page, it will not be possible?The `Symfony\Bridge\Monolog\Handler\MailerHandler` was added in `v5.1` (symfony/symfony#33456)Because the wording `compatible yet` implies that it will be compatible in the futureThank youedit: I do not understand the `DOCtor-RST` check here :sCommits-------202b9e6 Update messaged20f07c Fix: DOXtor-RST922932f Makes DOCtor-RST happy3df4d9e Document usage of Symfony Mailer for error email
How to use MailerHandler without framework ? |
This PR was squashed before being merged into the 3.x-dev branch.Discussion----------Add Symfony Mailer supportAdd support for the new symfony mailer directly on the bundle after the MailerHandle was added to the bridge onsymfony/symfony#33456Also this can makesymfony/symfony-docs#13077 move forwardTests are failing due to incompatible phpunit versions, not sure how to fix this...Commits-------0b832f2 Add Symfony Mailer support
Uh oh!
There was an error while loading.Please reload this page.