Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Sync string to date behavior and throw a better exception#33439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:3.4fromfancyweb:validator-better-throw-on-invalid-datesSep 3, 2019
Merged
[Validator] Sync string to date behavior and throw a better exception#33439
fabpot merged 1 commit intosymfony:3.4fromfancyweb:validator-better-throw-on-invalid-datesSep 3, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
10873a4 to28d7d94Comparero0NL approved these changesSep 3, 2019
fabpot approved these changesSep 3, 2019
Member
fabpot commentedSep 3, 2019
Thank you@fancyweb. |
fabpot added a commit that referenced this pull requestSep 3, 2019
…r exception (fancyweb)This PR was merged into the 3.4 branch.Discussion----------[Validator] Sync string to date behavior and throw a better exception| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -`\DateTimeImmutable` are not compared with `\DateTimeImmutable` in the `RangeValidator` class (contrary to the behavior in the `AbstractComparisonValidator` class).Also, let's throw a dedicated exception when the provided string value cannot be parsed to a `\DateTime` or `\DateTimeImmutable`. It's better than the default exception IMO.Commits-------28d7d94 [Validator] Sync string to date behavior and throw a better exception
Member
nicolas-grekas commentedSep 3, 2019
@fancyweb can you please submit the PR for 4.3? I don't know how to merge it and make tests pass. Thanks for your help. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\DateTimeImmutableare not compared with\DateTimeImmutablein theRangeValidatorclass (contrary to the behavior in theAbstractComparisonValidatorclass).Also, let's throw a dedicated exception when the provided string value cannot be parsed to a
\DateTimeor\DateTimeImmutable. It's better than the default exception IMO.