Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix #33427#33437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromsylfabre:bug_33427
Sep 3, 2019
Merged

Fix #33427#33437

fabpot merged 1 commit intosymfony:4.3fromsylfabre:bug_33427
Sep 3, 2019

Conversation

@sylfabre
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#33427
LicenseMIT
Doc PRnone

Fix#33427 by checking if the message returned by the intl-icu catalog is empty. If yes then the translator returns an empty string instead of runningformatIntl() which uses the constructor ofMessageFormatter which throws an exception with empty strings.

@fabpot
Copy link
Member

Thank you@sylfabre.

fabpot added a commit that referenced this pull requestSep 3, 2019
This PR was merged into the 4.3 branch.Discussion----------Fix#33427| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#33427| License       | MIT| Doc PR        | noneFix#33427 by checking if the message returned by the intl-icu catalog is empty. If yes then the translator returns an empty string instead of running `formatIntl()` which uses the constructor of `MessageFormatter` which throws an exception with empty strings.Commits-------414dcebFix#33427
@fabpotfabpot merged commit414dceb intosymfony:4.3Sep 3, 2019
@nicolas-grekasnicolas-grekas added this to the4.3 milestoneSep 3, 2019
@fabpotfabpot mentioned this pull requestOct 7, 2019
@sylfabresylfabre deleted the bug_33427 branchSeptember 25, 2020 13:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@sylfabre@fabpot@stof@yceruto@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp