Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Only handle numeric values in DivisibleBy#33435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Validator] Only handle numeric values in DivisibleBy#33435
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Validator/Constraints/DivisibleByValidator.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
6afa33e to13e8b44Comparefancyweb commentedSep 3, 2019
Now the only problem with it is that the values can be transformed in the |
ro0NL commentedSep 3, 2019
@fancyweb not sure i follow, the passed message still applies to numeric values. We get a different message/violation for type errors, like any other constraint does. |
fancyweb commentedSep 3, 2019
What I mean is that if my constraint is |
ro0NL commentedSep 3, 2019
i see, IMHO that's a side effect we can live with yes. |
13e8b44 tof974addComparefabpot commentedSep 3, 2019
Thank you@fancyweb. |
…cyweb)This PR was merged into the 4.3 branch.Discussion----------[Validator] Only handle numeric values in DivisibleBy| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Currently it probably breaks because `abs` throws a notice on objects.Commits-------f974add [Validator] Only handle numeric values in DivisibleBy
Currently it probably breaks because
absthrows a notice on objects.