Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add ConstraintValidator::formatValue() tests#33434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

So#33401 tests can be built on top of this.

@fancywebfancywebforce-pushed thevalidator-test-constraint-validator-format-value branch from78e13ed to8753531CompareSeptember 2, 2019 17:08
['"foo"', 'foo'],
['array', []],
['object', $toString = new TestToStringObject()],
['ccc', $toString, ConstraintValidator::OBJECT_TO_STRING],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it correct, that this test depends on the test before?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For me, it doesn't really depends of it. It just reuses the same object instance to avoid a new instantiation. It also highlights that the same object is formatted differently depending of the format parameter.

@fancywebfancywebforce-pushed thevalidator-test-constraint-validator-format-value branch from8753531 toa1771ecCompareSeptember 3, 2019 12:10
@fancywebfancyweb changed the base branch from4.4 to3.4September 3, 2019 13:02
@fancywebfancywebforce-pushed thevalidator-test-constraint-validator-format-value branch froma1771ec tod695754CompareSeptember 3, 2019 13:14
@fancywebfancywebforce-pushed thevalidator-test-constraint-validator-format-value branch fromd695754 to90ffed4CompareSeptember 3, 2019 15:24
@fancywebfancywebforce-pushed thevalidator-test-constraint-validator-format-value branch from90ffed4 toafb8d78CompareSeptember 3, 2019 15:50
@fabpotfabpotforce-pushed thevalidator-test-constraint-validator-format-value branch fromafb8d78 tob688aa3CompareSeptember 3, 2019 16:24
@fabpot
Copy link
Member

Thank you@fancyweb.

fabpot added a commit that referenced this pull requestSep 3, 2019
… (fancyweb)This PR was squashed before being merged into the 3.4 branch (closes#33434).Discussion----------[Validator] Add ConstraintValidator::formatValue() tests| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -So#33401 tests can be built on top of this.Commits-------b688aa3 [Validator] Add ConstraintValidator::formatValue() tests
@fabpotfabpot merged commitb688aa3 intosymfony:3.4Sep 3, 2019
@fancywebfancyweb deleted the validator-test-constraint-validator-format-value branchSeptember 3, 2019 17:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fancyweb@fabpot@OskarStark@ro0NL@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp