Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix #33395 PHP 5.3 compatibility#33396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromkylekatarnls:patch-2
Aug 30, 2019
Merged

Conversation

@kylekatarnls
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#33395
LicenseMIT

@michaljusiega
Copy link
Contributor

The minimum version of SF 3.4 isn't PHP 5.3 or I forgot something?

@kylekatarnls
Copy link
ContributorAuthor

The minimum compatibility of symfony/phpunit-bridge is PHP 5.3

@kylekatarnls
Copy link
ContributorAuthor

I used ^3.4 in my Travis-CI test for PHP 5.3 and it suddenly broke with the version 3.4.31.

@fabpot
Copy link
Member

Thank you@kylekatarnls.

fabpot added a commit that referenced this pull requestAug 30, 2019
This PR was merged into the 3.4 branch.Discussion----------Fix#33395 PHP 5.3 compatibility| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#33395| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------dede158Fix#33395 PHP 5.3 compatibility
@fabpotfabpot merged commitdede158 intosymfony:3.4Aug 30, 2019
@kylekatarnlskylekatarnls deleted the patch-2 branchAugust 30, 2019 18:07
@kylekatarnls
Copy link
ContributorAuthor

A pleasure to help as it's a pleasure to use Symfony.

sstok reacted with laugh emojisstok reacted with heart emoji

This was referencedOct 7, 2019
@fmonts
Copy link

Supporting EOL PHP versions should be considered a security vulnerability and fixed IMHO

@stof
Copy link
Member

stof commentedOct 8, 2019

@fmonts symfony/phpunit-bridge is about running tests. Allowing other projects supporting these PHP versions to use our uptodate test tool is actuallyreducing our maintenance burden.
And being a test tooling, the argument of PHP 5.3 being unmaintained and so being insecure does not hold (you won't use symfony/phpunit-bridge in production)

@fmonts
Copy link

hmm ok, it was just strange to read this commit message in the 4.3 changelog

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kylekatarnls@michaljusiega@fabpot@fmonts@stof@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp