Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] fix support for 103 Early Hints and other informational status codes#33391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
84782e2 to4ccf132CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
4ccf132 to60f771bCompareUh oh!
There was an error while loading.Please reload this page.
0a9982c tofb08681Compareyceruto approved these changesAug 31, 2019
cc9a012 to96bdf08Compare96bdf08 to34275bbComparedunglas approved these changesSep 3, 2019
nicolas-grekas added a commit that referenced this pull requestSep 3, 2019
…ormational status codes (nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] fix support for 103 Early Hints and other informational status codes| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -I learned quite recently how 1xx status codes work in HTTP 1.1 when I discovered the [103 Early Hint](https://evertpot.com/http/103-early-hints) status code from [RFC8297](https://tools.ietf.org/html/rfc8297)This PR fixes support for them by adding a new `getInformationalStatus()` method on `ChunkInterface`. This means that you can now know about 1xx status code by using the `$client->stream()` method:```php$response = $client->request('GET', '...');foreach ($client->stream($response) as $chunk) { [$code, $headers] = $chunk->getInformationalStatus(); if (103 === $code) { // $headers['link'] contains the early hints defined in RFC8297 } // ...}```Commits-------34275bb [HttpClient] fix support for 103 Early Hints and other informational status codes
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I learned quite recently how 1xx status codes work in HTTP 1.1 when I discovered the103 Early Hint status code fromRFC8297
This PR fixes support for them by adding a new
getInformationalStatus()method onChunkInterface. This means that you can now know about 1xx status code by using the$client->stream()method: