Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpClient] fix support for 103 Early Hints and other informational status codes#33391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedAug 30, 2019
edited
Loading

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

I learned quite recently how 1xx status codes work in HTTP 1.1 when I discovered the103 Early Hint status code fromRFC8297

This PR fixes support for them by adding a newgetInformationalStatus() method onChunkInterface. This means that you can now know about 1xx status code by using the$client->stream() method:

$response =$client->request('GET','...');foreach ($client->stream($response)as$chunk) {    [$code,$headers] =$chunk->getInformationalStatus();if (103 ===$code) {// $headers['link'] contains the early hints defined in RFC8297    }// ...}

Toflar, dunglas, ggekos, linaori, and andreybolonin reacted with heart emoji
@nicolas-grekasnicolas-grekasforce-pushed thehc-informational branch 2 times, most recently from0a9982c tofb08681CompareAugust 31, 2019 10:47
nicolas-grekas added a commit that referenced this pull requestSep 3, 2019
…ormational status codes (nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] fix support for 103 Early Hints and other informational status codes| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -I learned quite recently how 1xx status codes work in HTTP 1.1 when I discovered the [103 Early Hint](https://evertpot.com/http/103-early-hints) status code from [RFC8297](https://tools.ietf.org/html/rfc8297)This PR fixes support for them by adding a new `getInformationalStatus()` method on `ChunkInterface`. This means that you can now know about 1xx status code by using the `$client->stream()` method:```php$response = $client->request('GET', '...');foreach ($client->stream($response) as $chunk) {    [$code, $headers] = $chunk->getInformationalStatus();    if (103 === $code) {        // $headers['link'] contains the early hints defined in RFC8297    }    // ...}```Commits-------34275bb [HttpClient] fix support for 103 Early Hints and other informational status codes
@nicolas-grekasnicolas-grekas merged commit34275bb intosymfony:4.3Sep 3, 2019
@nicolas-grekasnicolas-grekas deleted the hc-informational branchSeptember 4, 2019 06:22
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@dunglasdunglasdunglas approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@ntzmntzmntzm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@dunglas@derrabus@yceruto@ntzm@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp