Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] maintain sender/recipient name in SMTP envelopes#33387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromxabbuh:issue-33383
Sep 4, 2019

Conversation

@xabbuh
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#33383
LicenseMIT
Doc PR

@xabbuh
Copy link
MemberAuthor

The build failure is unrelated to the changes.

@xabbuhxabbuhforce-pushed theissue-33383 branch 2 times, most recently from18339a0 toc1d2451CompareAugust 30, 2019 12:28
@xabbuh
Copy link
MemberAuthor

I found some more places. Ready to be reviewed now.

@fbourigault
Copy link
Contributor

fbourigault commentedAug 30, 2019
edited
Loading

AsAddress is an immutable object, it should be better to use those as-is instead of creating new instances.

Moreover, we are lacking some escaping to flawlessly use addresses names in email headers.

AFAIK, commas and double quotes have to be escaped.

I use the following code in my project which ATM use the official postmark client:

$name =preg_replace('/"/u','\"',$name);if (preg_match('/,/u',$name)) {$name =sprintf('"%s"',$name);        }

I quickly looked at RFC, but address grammar can be found inhttps://tools.ietf.org/html/rfc2822#section-3.4.

@fabpot
Copy link
Member

I think this one needs to be rebased on 4.3 as this is a bug fix, right?@xabbuh Can you rebase?

@xabbuhxabbuh changed the base branch from4.4 to4.3September 4, 2019 09:07
@xabbuhxabbuh modified the milestones:next,4.3Sep 4, 2019
@fabpot
Copy link
Member

Thank you@xabbuh.

fabpot added a commit that referenced this pull requestSep 4, 2019
…(xabbuh)This PR was merged into the 4.3 branch.Discussion----------[Mailer] maintain sender/recipient name in SMTP envelopes| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#33383| License       | MIT| Doc PR        |Commits-------46ed0e8 maintain sender/recipient name in SMTP envelopes
@fabpotfabpot merged commit46ed0e8 intosymfony:4.3Sep 4, 2019
@xabbuhxabbuh deleted the issue-33383 branchSeptember 4, 2019 10:09
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@fbourigaultfbourigaultfbourigault left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@fbourigault@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp