Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Fix about command not showing .env vars#33357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3frombohanwood:fix_about_env
Aug 30, 2019
Merged

[FrameworkBundle] Fix about command not showing .env vars#33357

fabpot merged 1 commit intosymfony:4.3frombohanwood:fix_about_env
Aug 30, 2019

Conversation

@bohanwood
Copy link

Before this fix,bin/console about can't properly showEnvironment (.env) section because:
SYMFONY_DOTENV_VARS which stores all keys of Dotenv-set env vars, is being fetched viagetenv().

However, in Symfony Dotenv 4.3, usage ofputenv() is deprecated:
symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334
so we can get env vars viagetenv() only whennew Dotenv(true).
In the default shippedconfig/bootstrap.php, there isnew Dotenv(false) set.

(Maybe related#29131)

QA
Branch?4.3 for bug fixes
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
LicenseMIT

kaznovac reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas added this to the4.3 milestoneAug 30, 2019
@fabpot
Copy link
Member

Thank you@brentybh.

fabpot added a commit that referenced this pull requestAug 30, 2019
…(brentybh)This PR was squashed before being merged into the 4.3 branch (closes#33357).Discussion----------[FrameworkBundle] Fix about command not showing .env varsBefore this fix, `bin/console about` can't properly show `Environment (.env)` section because:`SYMFONY_DOTENV_VARS` which stores all keys of Dotenv-set env vars, is being fetched via `getenv()`.However, in Symfony Dotenv 4.3, usage of `putenv()` is deprecated:symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334so we can get env vars via `getenv()` only when `new Dotenv(true)`.In the default shipped `config/bootstrap.php`, there is `new Dotenv(false)` set.(Maybe related#29131)| Q             | A| ------------- | ---| Branch?       | 4.3 for bug fixes <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------f48f19d [FrameworkBundle] Fix about command not showing .env vars
@fabpotfabpot merged commitf48f19d intosymfony:4.3Aug 30, 2019
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@berezuevberezuevberezuev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@bohanwood@fabpot@weaverryan@nicolas-grekas@berezuev@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp