Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Stop worker when it should stop#33298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromtienvx:stop-worker-when-it-should-stop
Aug 26, 2019
Merged

[Messenger] Stop worker when it should stop#33298

fabpot merged 1 commit intosymfony:4.3fromtienvx:stop-worker-when-it-should-stop
Aug 26, 2019

Conversation

@tienvx
Copy link
Contributor

@tienvxtienvx commentedAug 23, 2019
edited
Loading

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsNA
LicenseMIT
Doc PRNA

There are 2 things about this PR:

@tienvxtienvx changed the titleStop worker when it should stop[Messenger] Stop worker when it should stopAug 23, 2019
@nicolas-grekasnicolas-grekas added this to the4.3 milestoneAug 23, 2019
@fabpot
Copy link
Member

Thank you@tienvx.

fabpot added a commit that referenced this pull requestAug 26, 2019
This PR was merged into the 4.3 branch.Discussion----------[Messenger] Stop worker when it should stop| Q             | A| ------------- | ---| Branch?       | 4.3 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | NA   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | NA <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->There are 2 things about this PR:* This PR fix the bug when using `limit`, `memory-limit`, `time-limit` options with command `messenger:consume`, these options does not work if the receiver return multiple messages* This PR is the continue work of#32783Commits-------5c1f3a2 [Messenger] Stop worker when it should stop
@fabpotfabpot merged commit5c1f3a2 intosymfony:4.3Aug 26, 2019
@fabpotfabpot mentioned this pull requestAug 26, 2019
@tienvxtienvx deleted the stop-worker-when-it-should-stop branchAugust 26, 2019 23:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@tienvx@fabpot@chalasr@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp