Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make dispatched events really final#33297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromTobion:real-final-events
Sep 8, 2019

Conversation

@Tobion
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Continuation of#33152 for master

Copy link
Contributor

@ro0NLro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

shouldnt we update tests in 4.4 also?

derrabus reacted with thumbs up emoji
@Tobion
Copy link
ContributorAuthor

Extracted updating tests for 4.4 in#33482

nicolas-grekas added a commit that referenced this pull requestSep 6, 2019
This PR was merged into the 4.4 branch.Discussion----------fix tests mocking final events| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |Fix tests in 4.4 extracted from#33297Commits-------637461f fix tests mocking final events
@nicolas-grekas
Copy link
Member

rebase unlocked.

@Tobion
Copy link
ContributorAuthor

Rebased and tests pass

@fabpot
Copy link
Member

Thank you@Tobion.

fabpot added a commit that referenced this pull requestSep 8, 2019
This PR was merged into the 5.0-dev branch.Discussion----------Make dispatched events really final| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Continuation of#33152 for masterCommits-------953057f Make dispatched events really final
@fabpotfabpot merged commit953057f intosymfony:masterSep 8, 2019
@TobionTobion deleted the real-final-events branchSeptember 9, 2019 05:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Tobion@nicolas-grekas@fabpot@ro0NL@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp