Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add return types to tests and final|internal|private methods#33279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b08036f toa858383Comparec46dbe0 to92aae3bComparenicolas-grekas added a commit that referenced this pull requestAug 21, 2019
This PR was merged into the 3.4 branch.Discussion----------Backported return type violation bugfixes| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#33228| License | MIT| Doc PR | N/AFixed some doc blocks and broken return values discovered while working on#33279.Commits-------8877a01 Backported return type violation bugfixes.
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas added a commit that referenced this pull requestAug 21, 2019
…hods (nicolas-grekas, derrabus)This PR was merged into the 4.4 branch.Discussion----------Add return types to tests and final|internal|private methods| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#33228#33236| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->#33266 made me spot an issue with my logic to add return types with help from `DebugClassLoader`.Here is a completing PR, with the logic expanded to test classes.I need help to fix tests, /cc@derrabus :)Commits-------c39fd9c Fixed tests on the Security and Form componentsfc186bb Add return types to tests and final|internal|private methods
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33266 made me spot an issue with my logic to add return types with help from
DebugClassLoader.Here is a completing PR, with the logic expanded to test classes.
I need help to fix tests, /cc@derrabus :)