Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Mark all classes extending twig as @final#33269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromfabpot:twig-bridge-final-extensions
Aug 21, 2019

Conversation

@fabpot
Copy link
Member

QA
Branch?4.4
Bug fix?yes-ish
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsrefs#33039
LicenseMIT
Doc PRn/a

Classes defining extensions/nodes/node visitors/token parsers should not be changed. They should be final.

That would also help with Twig 3.0 which introduces type hints (including return types).

@yceruto
Copy link
Member

There are now some remaining deprecation warnings from SecurityBundle, FB and TwigBridge related toSymfony\Bridge\Twig\TokenParser\TransTokenParser.

@fabpot
Copy link
MemberAuthor

@yceruto "fixed". I don't see whyTransChoiceTokenParser extendsTransTokenParser (as no code is shared). I made it extendAbstractExtension instead.

@fabpotfabpotforce-pushed thetwig-bridge-final-extensions branch from2bb1e91 to9d37851CompareAugust 21, 2019 07:11
@fabpotfabpotforce-pushed thetwig-bridge-final-extensions branch from9d37851 tod657459CompareAugust 21, 2019 07:28
fabpot added a commit that referenced this pull requestAug 21, 2019
…(fabpot)This PR was merged into the 4.4 branch.Discussion----------[TwigBridge] Mark all classes extending twig as@Final| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes-ish| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | refs#33039| License       | MIT| Doc PR        | n/aClasses defining extensions/nodes/node visitors/token parsers should not be changed. They should be final.That would also help with Twig 3.0 which introduces type hints (including return types).Commits-------d657459 [TwigBridge] Mark all classes extending twig as@Final
@fabpotfabpot merged commitd657459 intosymfony:4.4Aug 21, 2019
@fabpotfabpot deleted the twig-bridge-final-extensions branchSeptember 7, 2019 12:04
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

@ycerutoycerutoyceruto approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@fabpot@yceruto@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp