Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[5.0] Add return types on internal|final|private methods#33259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c4c24b8 tocfe03c0Compare Merged
nicolas-grekas added a commit that referenced this pull requestAug 20, 2019
This PR was merged into the 3.4 branch.Discussion----------More docblock fixes| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Found while working on#33259Commits-------9b78d53 More docblock fixes
nicolas-grekas added a commit that referenced this pull requestAug 20, 2019
… (bis) (nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[4.4] Add return types on internal|final|private methods (bis)| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Found while working on#33259`: self` is used for final methods only. I'd have preferred using `: object` but that's not possible on PHP 7.1Commits-------23faee4 [4.4] Add return types on internal|final|private methods (bis)
nicolas-grekas added a commit that referenced this pull requestAug 20, 2019
… (nicolas-grekas)This PR was merged into the 5.0-dev branch.Discussion----------[5.0] Add return types on internal|final|private methods| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#33228#33236| License | MIT| Doc PR | -I think some changes here can be backported to 4.4Also, this fails with e.g. `Return value of Symfony\Component\Serializer\Normalizer\ArrayDenormalizer::denormalize() must be an object, array returned`Which means we need to update `DenormalizerInterface::denormalize()` with `@return object|array` in 3.4.Commits-------6f303b4 [5.0] Add return types on internal|final|private methods
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think some changes here can be backported to 4.4
Also, this fails with e.g.
Return value of Symfony\Component\Serializer\Normalizer\ArrayDenormalizer::denormalize() must be an object, array returnedWhich means we need to update
DenormalizerInterface::denormalize()with@return object|arrayin 3.4.