Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Router] Fix TraceableUrlMatcher behaviour with trailing slash#33244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@xavierleune
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32149
LicenseMIT
Doc PR¤

This pull requests fixes the bug#32149. This issue was about TraceableUrlMatcher having a wrong behaviour regarding trailing slashes (according to UrlMatcher and documentation).

With this pull requests, the test class TraceableUrlMatcherTest now extends UrlMatcherTest, to prevent such behaviour digression.

Thanks@nicolas-grekas for his feedback on the issue#32149

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneAug 19, 2019
@xavierleunexavierleuneforce-pushed the32149-traceableurlmatcher branch from8b1ff21 tofd1cb44CompareAugust 19, 2019 15:56
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I checked this is the same code asUrlMatcher, with calls toaddTrace() where needed.)

xavierleune reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Thank you@xavierleune.

OskarStark reacted with rocket emoji

nicolas-grekas added a commit that referenced this pull requestAug 20, 2019
…lash (Xavier Leune)This PR was merged into the 3.4 branch.Discussion----------[Router] Fix TraceableUrlMatcher behaviour with trailing slash| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32149| License       | MIT| Doc PR        | ¤<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->This pull requests fixes the bug#32149. This issue was about TraceableUrlMatcher having a wrong behaviour regarding trailing slashes (according to UrlMatcher and documentation).With this pull requests, the test class TraceableUrlMatcherTest now extends UrlMatcherTest, to prevent such behaviour digression.Thanks@nicolas-grekas for his feedback on the issue#32149Commits-------fd1cb44 [Router] Fix TraceableUrlMatcher behaviour with trailing slash
@nicolas-grekasnicolas-grekas merged commitfd1cb44 intosymfony:3.4Aug 20, 2019
This was referencedAug 26, 2019
@xavierleunexavierleune deleted the 32149-traceableurlmatcher branchAugust 27, 2019 16:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark left review comments

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xavierleune@nicolas-grekas@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp