NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fix getMaxFilesize() returning zero#33157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromausi:fix/get-max-filesize

Aug 14, 2019

Merged

Fix getMaxFilesize() returning zero#33157

fabpot merged 1 commit intosymfony:3.4fromausi:fix/get-max-filesize

Aug 14, 2019

Conversation

Copy link

Contributor

ausi commentedAug 14, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32790
License	MIT

With#32790 a BC break got introduced. Previously an emptyupload_max_filesize returnedPHP_INT_MAX but after the changes from#32790 it returns0.

Settingupload_max_filesize orpost_max_size to0 or'' disables the limit so for both casesPHP_INT_MAX should be returned.

carsonbot added Status: Needs Review Bug labels

Aug 14, 2019

Fix getMaxFilesize() returning zero

f4c2ea5

ausi force-pushed thefix/get-max-filesize branch from3776298 tof4c2ea5Compare

August 14, 2019 06:35

ausi referenced this pull request

Aug 14, 2019

[HttpFoundation] FixgetMaxFilesize

54107ba

Copy link

ContributorAuthor

I didn’t find a way to mock theini_get() function to create better tests. I tried a similar approach as theClockMock class from the phpunit-bridge but it didn’t work as it seems thatini_get() cannot be overwritten with a namespaced function on the fly.

fabpot approved these changes

Aug 14, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 14, 2019

Copy link

Member

fabpot commentedAug 14, 2019

Thank you@ausi.

fabpot merged commitf4c2ea5 intosymfony:3.4

Aug 14, 2019

fabpot added a commit that referenced this pull request

Aug 14, 2019

bug#33157Fix getMaxFilesize() returning zero (ausi)

b382e62

This PR was merged into the 3.4 branch.Discussion----------Fix getMaxFilesize() returning zero| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32790| License       | MITWith#32790 a BC break got introduced. Previously an empty `upload_max_filesize` returned `PHP_INT_MAX` but after the changes from#32790 it returns `0`.Setting `upload_max_filesize` or `post_max_size` to `0` or `''` disables the limit so for both cases `PHP_INT_MAX` should be returned.Commits-------f4c2ea5 Fix getMaxFilesize() returning zero