Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Excludes locale from language codes (split localized language names)#33148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
ro0NL commentedAug 14, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
if this is decided for 3.4, then 4.4 needs another PR to patch edit: actually no, we should do 4.4 (we qualified excluding codes a new feature before as well (https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Intl/CHANGELOG.md) |
fabpot commentedSep 25, 2019
@ro0NL Anything left in this PR before merging (a rebase is needed anyway)? |
ro0NL commentedSep 27, 2019
fabpot commentedSep 27, 2019
ro0NL commentedSep 27, 2019
done. |
fabpot commentedSep 27, 2019
Thank you@ro0NL. |
…lized language names) (ro0NL)This PR was merged into the 4.4 branch.Discussion----------[Intl] Excludes locale from language codes (split localized language names)| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#33146| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->(includes#33140)Commits-------1a9f517 [Intl] Excludes locale from language codes (split localized language names)
nicolas-grekas commentedSep 27, 2019
Looks like this broke some tests, could you have a look@ro0NL please? |
This PR was merged into the 3.4 branch.Discussion----------[Form][Validator][Intl] Fix tests| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#33148 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------e648a91 [Form][Validator][Intl] Fix tests
Uh oh!
There was an error while loading.Please reload this page.
(includes#33140)