Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Intl] Excludes locale from language codes (split localized language names)#33148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromro0NL:intl-lang-locale
Sep 27, 2019
Merged

[Intl] Excludes locale from language codes (split localized language names)#33148

fabpot merged 1 commit intosymfony:4.4fromro0NL:intl-lang-locale
Sep 27, 2019

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedAug 13, 2019
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#33146
LicenseMIT
Doc PRsymfony/symfony-docs#...

(includes#33140)

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedAug 14, 2019
edited
Loading

if this is decided for 3.4, then 4.4 needs another PR to patchgetAlpha3Name as well

edit: actually no, we should do 4.4 (we qualified excluding codes a new feature before as well (https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Intl/CHANGELOG.md)

@fabpot
Copy link
Member

@ro0NL Anything left in this PR before merging (a rebase is needed anyway)?

@ro0NL
Copy link
ContributorAuthor

@fabpot done (also see#33734)

@fabpot
Copy link
Member

@ro0NL Can you rebase to get rid of#3374 commit?

@ro0NL
Copy link
ContributorAuthor

done.

@fabpot
Copy link
Member

Thank you@ro0NL.

fabpot added a commit that referenced this pull requestSep 27, 2019
…lized language names) (ro0NL)This PR was merged into the 4.4 branch.Discussion----------[Intl] Excludes locale from language codes (split localized language names)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#33146| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->(includes#33140)Commits-------1a9f517 [Intl] Excludes locale from language codes (split localized language names)
@fabpotfabpot merged commit1a9f517 intosymfony:4.4Sep 27, 2019
@ro0NLro0NL deleted the intl-lang-locale branchSeptember 27, 2019 10:22
@nicolas-grekas
Copy link
Member

Looks like this broke some tests, could you have a look@ro0NL please?

nicolas-grekas added a commit that referenced this pull requestSep 27, 2019
This PR was merged into the 3.4 branch.Discussion----------[Form][Validator][Intl] Fix tests| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#33148 (comment)| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------e648a91 [Form][Validator][Intl] Fix tests
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@TerjeBrTerjeBrTerjeBr requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ro0NL@fabpot@nicolas-grekas@TerjeBr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp