@TerjeBr i resolved all your reviews, i think we have to settle here for now :) Thanks for reviewing, much appreciated. If i forgot or overlooked any of your concerns still, let me know.

TerjeBr approved these changes

Aug 14, 2019

View reviewed changes

src/Symfony/Component/Intl/Tests/LanguagesTest.phpShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Aug 14, 2019

nicolas-grekas added a commit that referenced this pull request

Aug 14, 2019

minor#33158[Intl] Explicit check (ro0NL)

990a149

This PR was merged into the 3.4 branch.Discussion----------[Intl] Explicit check| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This avoids a little conflict with#33140data is not impacted (today), but i like to make our data selection as explicit as possible and avoid ever pulling in `deprecated` or e.g. `legacy` languages.Commits-------fbd4ce4 [Intl] Explicit check

[Intl] Full alpha3 language support

29aee2d

Copy link

Member

fabpot commentedAug 18, 2019

Thank you@ro0NL.

fabpot added a commit that referenced this pull request

Aug 18, 2019

bug#33140[Intl] Full alpha3 language support (ro0NL)

9130c6a

This PR was merged into the 4.4 branch.Discussion----------[Intl] Full alpha3 language support| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#33136| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->I'll validate some more cases with tests.Commits-------29aee2d [Intl] Full alpha3 language support

fabpot merged commit29aee2d intosymfony:4.4

Aug 18, 2019

ro0NL deleted the lang-alpha3 branch

August 19, 2019 10:23

fabpot added a commit that referenced this pull request

Sep 27, 2019

feature#33148[Intl] Excludes locale from language codes (split loca…

161975d

…lized language names) (ro0NL)This PR was merged into the 4.4 branch.Discussion----------[Intl] Excludes locale from language codes (split localized language names)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#33146| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->(includes#33140)Commits-------1a9f517 [Intl] Excludes locale from language codes (split localized language names)