Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument#33131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument#33131
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yceruto left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The next step would be to add the \TypeError in master/5.0, no?
src/Symfony/Component/Form/ChoiceList/Factory/ChoiceListFactoryInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
vudaltsov commentedAug 12, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, I will do that in#32237 |
073c248 to8f5d1caComparenicolas-grekas commentedAug 13, 2019
Thank you@vudaltsov. |
…teView $label argument (vudaltsov)This PR was merged into the 3.4 branch.Discussion----------[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aReplaces#33074Ping@nicolas-grekas ,@Tobion ,@yceruto .Commits-------8f5d1ca Add false type to ChoiceListFactoryInterface::createView $label argument
Replaces#33074
Ping@nicolas-grekas ,@Tobion ,@yceruto .