NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Config] Add handling for ignored keys in ArrayNode::mergeValues.#33124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.3fromalex-dev:4.3

Aug 20, 2019

Merged

[Config] Add handling for ignored keys in ArrayNode::mergeValues.#33124

nicolas-grekas merged 1 commit intosymfony:4.3fromalex-dev:4.3

Aug 20, 2019

Conversation

Copy link

Contributor

alex-dev commentedAug 12, 2019

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#33101
License	MIT
Doc PR	N/A

Fix case where normalized data accepting and keeping ignored keys is rejected during merge.

carsonbot added Status: Needs Review Config Bug labels

Aug 12, 2019

Copy link

ContributorAuthor

alex-dev commentedAug 12, 2019

Code styling issues were not fixed to minimize impact.
I've got no idea what is broken in Travis 7.2, looks like Twig Bridge is missing a PSR-13 related class.

nicolas-grekas added this to the4.3 milestone

Aug 13, 2019

nicolas-grekas reviewed

Aug 13, 2019

View reviewed changes

src/Symfony/Component/Config/Definition/ArrayNode.php OutdatedShow resolvedHide resolved

nicolas-grekas approved these changes

Aug 13, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 13, 2019

Copy link

deluxetom commentedAug 14, 2019

tried these changes as I was hitting the same issue and it works with them, can't wait for this PR to go live

[Config] Add handling for ignored keys in ArrayNode::mergeValues.

311e1c4

Copy link

Member

nicolas-grekas commentedAug 20, 2019

Thank you@alex-dev.

nicolas-grekas added a commit that referenced this pull request

Aug 20, 2019

bug#33124[Config] Add handling for ignored keys in ArrayNode::merge…

c3ccd2a

…Values. (Alexandre Parent)This PR was squashed before being merged into the 4.3 branch (closes#33124).Discussion----------[Config] Add handling for ignored keys in ArrayNode::mergeValues.| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#33101| License       | MIT| Doc PR        | N/AFix case where normalized data accepting and keeping ignored keys is rejected during merge.Commits-------311e1c4 [Config] Add handling for ignored keys in ArrayNode::mergeValues.