Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Validate class-like service IDs#33111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedAug 11, 2019
From the original issue, im not sure happens in 3.4, i got the error athttps://github.com/symfony/symfony/pull/33111/files#diff-81d8d6906c0de563850dc240f5a1d213R77 |
| } | ||
| if (preg_match('/^\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+(?:\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*+)++$/',$id)) { | ||
| thrownewRuntimeException(sprintf( | ||
| 'The definition for "%s" has no class attribute, and appears to reference a class or interface.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and appears to reference a class or interface
actually not, since the class doesn't exist
that + the fact that the message reported in#33092 is not the one just below, I'm not sure this PR is the correct answer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you're right. Let's continue in#33108
AFAIK the if block at L51 is now dead code :/
Uh oh!
There was an error while loading.Please reload this page.
Alternative approach of#33092 for 3.4 (enables to continue#33108 for 4.3)
cc@fabpot@nicolas-grekas