Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Bump minimal requirements#33094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $this->expectException('Symfony\Component\DependencyInjection\Exception\RuntimeException'); | ||
| $this->expectExceptionMessage('The definitionfor"\Symfony\Component\DependencyInjection\Tests\FooClass" has no class attribute, andappears to reference a class or interface. Please specify the class attribute explicitly orremove the leading backslash by renaming the service to "Symfony\Component\DependencyInjection\Tests\FooClass" to get rid of this error.'); | ||
| $this->expectException('Symfony\Component\DependencyInjection\Exception\InvalidArgumentException'); | ||
| $this->expectExceptionMessage('Service definition "\Symfony\Component\DependencyInjection\Tests\FooClass" has no class, andits name looks like a FQCN but it starts with a backslash;remove the leading backslash.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FromCheckDefinitionValidityPass!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
perhaps im onto something -#33092 (comment)
9d87545 to4b1dcc5Compare| $a[0] = &$a; | ||
| /** | ||
| * This test is identical to testFailingSerialization, but the tested data causes a segfault in PHP 7.2 | ||
| * https://github.com/sebastianbergmann/phpunit/issues/3790. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Opened an issue in PHPhttps://bugs.php.net/78397
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed by#33110
nicolas-grekas commentedAug 10, 2019
Thank you@jderusse. |
This PR was merged into the 4.3 branch.Discussion----------Bump minimal requirements| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? || Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow up#33079 Fix failures with lowest requirements in branch 4.3Commits-------c874d3b Bump minimal requirements
Follow up#33079 Fix failures with lowest requirements in branch 4.3