Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[EventDispatcher] wrong Request class#33093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
yceruto merged 1 commit intosymfony:4.3frommaxhelias:type
Aug 9, 2019
Merged

Conversation

@maxhelias
Copy link
Contributor

@maxheliasmaxhelias commentedAug 9, 2019
edited
Loading

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

@yceruto
Copy link
Member

Should be fixed since 4.3

@maxheliasmaxhelias changed the base branch frommaster to4.3August 9, 2019 13:58
@maxheliasmaxhelias changed the title[5.0][EventDispatcher] wrong Request class[EventDispatcher] wrong Request classAug 9, 2019
@maxhelias
Copy link
ContributorAuthor

@yceruto Indeed, I changed the target branch, thanks 😃

@yceruto
Copy link
Member

Good catch, thanks@maxhelias.

maxhelias reacted with thumbs up emoji

@ycerutoyceruto merged commit97d6184 intosymfony:4.3Aug 9, 2019
yceruto added a commit that referenced this pull requestAug 9, 2019
This PR was merged into the 4.3 branch.Discussion----------[EventDispatcher] wrong Request class| Q             | A| ------------- | ---| Branch?       | 4.3 <!-- see below -->| Bug fix?      | yes| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | - <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------97d6184 [EventDispatcher] wrong Request class
@maxheliasmaxhelias deleted the type branchAugust 9, 2019 14:19
@fabpotfabpot mentioned this pull requestAug 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@seriquynhseriquynhseriquynh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@maxhelias@yceruto@xabbuh@seriquynh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp