NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Use PHPUnit 8.3 on Travis when possible#33072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nicolas-grekas wants to merge1 commit intosymfony:3.4fromnicolas-grekas:phpunit8

Closed

Use PHPUnit 8.3 on Travis when possible#33072

nicolas-grekas wants to merge1 commit intosymfony:3.4fromnicolas-grekas:phpunit8

Conversation

Copy link

Member

nicolas-grekas commentedAug 8, 2019

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

We just achieved running PHPUnit 8.2 on PHP 7.4, let's ensure it continues running by using it on a primary job.

nicolas-grekas added this to the3.4 milestone

Aug 8, 2019

carsonbot added the Status: Needs Review label

Aug 8, 2019

jderusse approved these changes

Aug 8, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 8, 2019

Tobion approved these changes

Aug 8, 2019

View reviewed changes

nicolas-grekas force-pushed thephpunit8 branch 2 times, most recently fromfcb3edf toea25756Compare

August 8, 2019 21:35

nicolas-grekas changed the title~~Use PHPUnit 8.2 on Travis when possible~~Use PHPUnit 8.3 on Travis when possible

Aug 8, 2019

fabpot approved these changes

Aug 9, 2019

View reviewed changes

Copy link

Member

jderusse commentedAug 9, 2019•
edited
Loading

test are failing because ofprefer-lowest, and TestCase extends other package AbsatractTest

inBundle/FrameworkBundle minimum version ofsymfony/http-kernel should be3.4@dev (next release)
in/Bridge/Twig minimum version ofsymfony/form should be3.4@dev
in/ minimum version ofsymfony/phpunit-bridge should be3.4@dev

we may hold this PR untill the next release in order to properly set the mimum version

Copy link

MemberAuthor

nicolas-grekas commentedAug 9, 2019

we may hold this PR untill the next release in order to properly set the mimum version

this is never needed, we do reference unreleased next-versions and it just works

jderusse mentioned this pull request

Aug 9, 2019

Use PHPUnit 8.3 on Travis when possible#33079

Merged

nicolas-grekas added a commit that referenced this pull request

Aug 9, 2019

minor#33079Use PHPUnit 8.3 on Travis when possible (nicolas-grekas,…

6b1ddd1

… jderusse)This PR was merged into the 3.4 branch.Discussion----------Use PHPUnit 8.3 on Travis when possible| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Followup#33072 to fix dependency resolutionCommits-------41d94c3 Bump minimal requirementsde5256b Use PHPUnit 8.3 on Travis when possible