Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Fix s-maxage=3 transient test#33051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromjderusse:fix-transient-test
Aug 8, 2019

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedAug 8, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsNA
LicenseMIT
Doc PRNA

sometime the http server returns as-maxage=3 header (https://travis-ci.org/symfony/symfony/jobs/569326531)
This PR fixes tests to allow both 2 and 3

@jderussejderusse changed the base branch from4.3 to3.4August 8, 2019 13:13
@jderusse
Copy link
MemberAuthor

fail test not related to this PR. (fixed in#33055)

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneAug 8, 2019
@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commitf019b52 intosymfony:3.4Aug 8, 2019
nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Fix s-maxage=3 transient test| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | NA| License       | MIT| Doc PR        | NAsometime the http server returns a `s-maxage=3` header (https://travis-ci.org/symfony/symfony/jobs/569326531)This PR fixes tests to allow both 2 and 3Commits-------f019b52 Fix s-maxage=3 transient test
@jderussejderusse deleted the fix-transient-test branchMarch 5, 2020 20:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@jderusse@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp