Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Make HttpClientTestCase compatible with PHPUnit8#33045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromjderusse:compat-httpClientTestCase-phpunit8Aug 8, 2019
Merged
Make HttpClientTestCase compatible with PHPUnit8#33045
nicolas-grekas merged 1 commit intosymfony:4.3fromjderusse:compat-httpClientTestCase-phpunit8Aug 8, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c8c717c to84a6690CompareUh oh!
There was an error while loading.Please reload this page.
84a6690 to55daf15CompareMember
nicolas-grekas commentedAug 8, 2019
Thank you@jderusse. |
nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was merged into the 4.3 branch.Discussion----------Make HttpClientTestCase compatible with PHPUnit8| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | NAthe abstract class `HttpClientTestCase` may be extends by end user and execute by both PHPUnit 8 and bellow. Adding a return typehint on it will force all users extending it to add it too and would be a BC Break.Note. I don't know how to trigger a deprecation here and help user to add it.Commits-------55daf15 Fix compatibility with PHPUnit 8
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the abstract class
HttpClientTestCasemay be extends by end user and execute by both PHPUnit 8 and bellow. Adding a return typehint on it will force all users extending it to add it too and would be a BC Break.Note. I don't know how to trigger a deprecation here and help user to add it.