Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Drop Debug compatibility layers#33027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr commentedAug 7, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas commentedAug 8, 2019
composer.json needs to be updated too, to remove the classmap entry |
fancyweb commentedAug 8, 2019
@chalasr Line 137 in Console Application.php -> |
chalasr commentedAug 8, 2019
@fancyweb fixed, thank you. @nicolas-grekas if you mean the one added by#32873 (comment), it was reverted there |
chalasr commentedAug 8, 2019
Removed the |
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bridge/ProxyManager/Legacy/ProxiedMethodReturnExpression.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| if ($phpHandler =set_exception_handler($renderException)) { | ||
| restore_exception_handler(); | ||
| if (!\is_array($phpHandler) || (!$phpHandler[0]instanceof ErrorHandler && !$phpHandler[0]instanceof LegacyErrorHandler)) { | ||
| if (!\is_array($phpHandler) || (!$phpHandler[0]instanceof ErrorHandler)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
extra brackets should be removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
right! done
nicolas-grekas commentedAug 8, 2019
Thank you@chalasr. |
This PR was merged into the 5.0-dev branch.Discussion----------Drop Debug compatibility layers| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------2326b80 [Debug] Drop compatibility layers