Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] fix nullable phpdocs and useless method visibility of internal class#33020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * | ||
| * @return Transformer[] Associative array of Transformer objects (format char => Transformer) | ||
| */ | ||
| publicfunctiongetTransformers() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is an internal class
nicolas-grekasAug 8, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we should change this class on 4.4
I get it's internal, but let's keep 3.4 super-stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
change reverted while merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nicolas-grekas commentedAug 8, 2019
Thank you@Tobion. |
…y of internal class (Tobion)This PR was merged into the 3.4 branch.Discussion----------[Intl] fix nullable phpdocs and useless method visibility of internal class| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |Fix stuff found in#32525Commits-------63b71b5 [Intl] fix nullable phpdocs and useless method visibility of internal class
…ransformer (Tobion)This PR was merged into the 4.4 branch.Discussion----------cleanup remaining param $options and internal Intl FullTransformer| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |Continuation of#33020 and#33019Commits-------5dbcdc6 cleanup remaining param and internal Intl FulLTransformer
Fix stuff found in#32525