Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Remove unneeded phpdocs#33019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove unneeded phpdocs#33019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedAug 7, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
src/Symfony/Component/HttpKernel/Fragment/HIncludeFragmentRenderer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Form/Extension/Csrf/Type/FormTypeCsrfExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
3273208 to692a6e7Comparenicolas-grekas commentedAug 8, 2019
Thank you@fabpot. |
This PR was squashed before being merged into the 4.4 branch (closes#33019).Discussion----------Remove unneeded phpdocs| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a| License | MIT| Doc PR | n/aCommits-------692a6e7 Remove unneeded phpdocs
kaznovac left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
some impovements
| * @param object $subject | ||
| * @param Marking $marking | ||
| * @param Transition $transition | ||
| * @param WorkflowInterface $workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$workflow is not typehinted in _constructor
possible types WorkflowInterface|string|null
| * @param Definition $definition A Definition instance | ||
| * @param Marking|null $marking A Marking instance | ||
| * @param array $options An array of options | ||
| * @param array $options An array of options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can be removed
| * @param string $class The class name of the loaded objects | ||
| * @param IdReader|null $idReader The reader for the object IDs | ||
| * @param EntityLoaderInterface|null $objectLoader The objects loader | ||
| * @param string $class The class name of the loaded objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typehinted in constructor maybe surplus
| * * name: name of described service | ||
| * | ||
| * @param Definition|Alias|object $service | ||
| * @param array $options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typehinted
| * @param KernelInterface $kernel A KernelInterface instance | ||
| * @param TemplateNameParserInterface $parser A TemplateNameParserInterface instance | ||
| * @param string $rootDir The directory where global templates can be stored | ||
| * @param string $rootDir The directory where global templates can be stored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typehinted maybe needed
| * trans_sid_hosts, $_SERVER['HTTP_HOST'] | ||
| * trans_sid_tags, "a=href,area=href,frame=src,form=" | ||
| * | ||
| * @param array $options Session configuration options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no additional value
| * @param Request $request The request the kernel is currently processing | ||
| * @param int $requestType The request type the kernel is currently processing; one of | ||
| * HttpKernelInterface::MASTER_REQUEST or HttpKernelInterface::SUB_REQUEST | ||
| * @param int $requestType The request type the kernel is currently processing; one of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
int|null
| * @param \DOMElement $node Element to parse | ||
| * @param string $path Full path of the XML file being processed | ||
| * @param string $file Loaded file name | ||
| * @param \DOMElement $node Element to parse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
inferable
| * | ||
| * @param MessageCatalogue $messages The message catalogue | ||
| * @param array $options Options that are used by the dumper | ||
| * @param array $options Options that are used by the dumper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no additional value
| * caused the violation | ||
| * @param mixed $cause The cause of the violation | ||
| * @param string $message The violation message | ||
| * @param string $messageTemplate The raw violation message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lots of |null types can be stated in doc ($message, $messageTemplate, $propertyPath)
…ransformer (Tobion)This PR was merged into the 4.4 branch.Discussion----------cleanup remaining param $options and internal Intl FullTransformer| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |Continuation of#33020 and#33019Commits-------5dbcdc6 cleanup remaining param and internal Intl FulLTransformer