Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Support ISO 3166-1 Alpha-3 country codes#32988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
terjebraten-certua commentedAug 6, 2019
This a continuation of#32676 |
Uh oh!
There was an error while loading.Please reload this page.
terjebraten-certua commentedAug 8, 2019
@derrabus Could you please complete your review? |
derrabus commentedAug 8, 2019
@terjebraten-certua I'm not familiar enough with the component to approve your changes, but I would trust that@ro0NL's review has been thorough. 😃 Status: Reviewed |
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
with some minor CS comments
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
terjebraten-certua commentedAug 9, 2019
@fabpot I did all the changes you requested. |
fabpot commentedAug 9, 2019
Thank you@terjebraten-certua. |
…braten-certua)This PR was merged into the 4.4 branch.Discussion----------[Intl] Support ISO 3166-1 Alpha-3 country codes| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20313| Doc PR |symfony/symfony-docs#12105| License | MITThis is a pre-requiste for fixing#20313 and only handles the changes to the INTL component.Commits-------848f60e Support ISO 3166-1 Alpha-3 country codes
TerjeBr commentedAug 13, 2019
…axperrimond)This PR was squashed before being merged into the 5.1-dev branch (closes#35116).Discussion----------[Validator] Add alpha3 option to country constraint| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets || License | MIT| Doc PR |symfony/symfony-docs#12857A following of#33791 and#32988 to add `alpha3` option also to `Country` constraint in the validator component.Commits-------d6f34a5 [Validator] Add alpha3 option to country constraint
Uh oh!
There was an error while loading.Please reload this page.
This is a pre-requiste for fixing#20313 and only handles the changes to the INTL component.