Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix tests/code for php 7.4#32981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
914c8b7 toe0dda4fComparenicolas-grekas approved these changesAug 6, 2019
23 tasks
Member
nicolas-grekas commentedAug 7, 2019
Thank you@jderusse. |
nicolas-grekas added a commit that referenced this pull requestAug 7, 2019
This PR was merged into the 3.4 branch.Discussion----------Fix tests/code for php 7.4| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | NAFix remaining tests and deprecationCommits-------05ec8a0 Fix remaining tests
nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was merged into the 4.3 branch.Discussion----------Fix deprecations on 4.3| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | NAFix deprecations in branch 4.3note: remaining deprecation `assertStringContainsString` will be fixed in#32977* [ ] fix tests in branch 3.4 in#32981Commits-------8fd16a6 Fix deprecation on 4.3
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix remaining tests and deprecation