Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
"An instance of X" phpdocs removal#32973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
22e3427 tofb9bf39Comparefb9bf39 tob45a526Comparefabpot commentedAug 6, 2019
fabbot errors are false positive. |
nicolas-grekas commentedAug 6, 2019
For 4.4 at least so that we reduce merge conflict? |
fabpot commentedAug 6, 2019
@nicolas-grekas I spent enough time on this. 5.0 is good enough for me. |
| * @throws \LogicException | ||
| */ | ||
| publicfunctiongenerateUri($request,$path) | ||
| publicfunctiongenerateUri(Request$request,$path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I ported the patch in this PR on 4.4 in#32974, but this file must be updated on master only, so it's not part of that other PR.
nicolas-grekas commentedAug 6, 2019
Closing for#32974 |
This PR was merged into the 4.4 branch.Discussion----------"An instance of X" phpdocs removal| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -That's#32973 on 4.4 :PCommits-------7a44ed6 removed unneeded phpdocs
Uh oh!
There was an error while loading.Please reload this page.
This PR removes all phpdocs referring to instances of X
@param X $x A X instance(or similar).