NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

add yceruto as code owner of the ErrorRenderer component#32964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4fromyceruto:error_renderer_code_owner

Aug 6, 2019

Merged

add yceruto as code owner of the ErrorRenderer component#32964

nicolas-grekas merged 1 commit intosymfony:4.4fromyceruto:error_renderer_code_owner

Aug 6, 2019

Conversation

Copy link

Member

yceruto commentedAug 5, 2019•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT

carsonbot added the Status: Needs Review label

Aug 5, 2019

yceruto force-pushed theerror_renderer_code_owner branch 2 times, most recently from286c2f9 to1a57c09Compare

August 5, 2019 20:28

yceruto changed the base branch from3.4 to4.4

August 5, 2019 20:32

yceruto force-pushed theerror_renderer_code_owner branch from1a57c09 toeea4aadCompare

August 5, 2019 20:32

chalasr approved these changes

Aug 5, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 5, 2019

fabpot reviewed

Aug 6, 2019

View reviewed changes

src/Symfony/Component/ErrorRenderer/composer.jsonShow resolvedHide resolved

nicolas-grekas added this to thenext milestone

Aug 6, 2019

yceruto force-pushed theerror_renderer_code_owner branch from0317427 to2e8e15cCompare

August 6, 2019 12:12

add yceruto as code owner of the ErrorRenderer component

df6e73d

nicolas-grekas force-pushed theerror_renderer_code_owner branch from2e8e15c todf6e73dCompare

August 6, 2019 12:17

Copy link

Member

nicolas-grekas commentedAug 6, 2019

Thank you@yceruto.

nicolas-grekas merged commitdf6e73d intosymfony:4.4

Aug 6, 2019

nicolas-grekas added a commit that referenced this pull request

Aug 6, 2019

minor#32964add yceruto as code owner of the ErrorRenderer component…

fc8872f

… (yceruto)This PR was squashed before being merged into the 4.4 branch (closes#32964).Discussion----------add yceruto as code owner of the ErrorRenderer component| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITCommits-------df6e73d add yceruto as code owner of the ErrorRenderer component

yceruto deleted the error_renderer_code_owner branch

August 6, 2019 12:22

nicolas-grekas modified the milestones:next,4.4

Oct 27, 2019