Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Use namespaced Phpunit classes#32941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jderusse commentedAug 5, 2019
.travis.yml Outdated
| # phpunit-bridge as a separate PR against the next feature-branch then | ||
| # uncomment and update the following line with that PR number | ||
| #SYMFONY_PHPUNIT_BRIDGE_PR=32886 | ||
| SYMFONY_PHPUNIT_BRIDGE_PR=32940 |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
must be reverted before merging
6b16fe3 to8675a53Comparebd9f3ae todfcc04aComparenicolas-grekas approved these changesAug 5, 2019
nicolas-grekas added a commit that referenced this pull requestAug 5, 2019
…erusse)This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] Add polyfill for PhpUnit namespace| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? |no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | NAThis PR provides PhpUnit >= 6 Namespaces class.This will simplify tests that have to be compatible with multiple version of PHPUnit```diff- if (class_exists('PHPUnit_Foo')) {- PHPUnit_Foo::bar():- } else {- \PHPUnit\Foo::bar();- }+ \PHPUnit\Foo::bar();```WIP => waiting for#32941 to be greenCommits-------b7520f7 Add polyfill for PhpUnit namespace
dfcc04a to797ea2eCompareMember
nicolas-grekas commentedAug 5, 2019
Thank you@jderusse. |
nicolas-grekas added a commit that referenced this pull requestAug 5, 2019
This PR was squashed before being merged into the 3.4 branch (closes#32941).Discussion----------Use namespaced Phpunit classes| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | need#32940| Fixed tickets |#32844| License | MIT| Doc PR | NAThis PR simplify tests by using PhpUnit namespace introduced in#32940It also makes compatible with PHPUnit 8 (removed class PHPUnit_Framework_MockObject_MockObject)Commits-------797ea2e Use namespaced Phpunit classes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplify tests by using PhpUnit namespace introduced in#32940
It also makes compatible with PHPUnit 8 (removed class PHPUnit_Framework_MockObject_MockObject)