Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] type cannot be a FormTypeInterface anymore#32934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromTobion:fix-form-types
Aug 5, 2019

Conversation

@Tobion
Copy link
Contributor

@TobionTobion commentedAug 4, 2019•
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Found in#32237. This style of adding FormTypes has been removed in sf 3. Could also be merged in 3.4 if preferred. But there was an outdated, broken test. So 4.4 seems enough as well.

Copy link
Contributor

@vudaltsovvudaltsov left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Symfony\Component\Form\Tests\FormBuilderTest::testAddFormType should now go to the legacy group.

@Tobion
Copy link
ContributorAuthor

I removed the outdated test.

vudaltsov reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@Tobion.

@fabpotfabpot merged commit6ee0d53 intosymfony:4.4Aug 5, 2019
fabpot added a commit that referenced this pull requestAug 5, 2019
This PR was merged into the 4.4 branch.Discussion----------[Form] type cannot be a FormTypeInterface anymore| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Found in#32237. This style of adding FormTypes has been removed in sf 3. Could also be merged in 3.4 if preferred. But there was an outdated, broken test. So 4.4 seems enough as well.Commits-------6ee0d53 [Form] type cannot be a FormTypeInterface anymore
@TobionTobion deleted the fix-form-types branchAugust 20, 2019 21:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

+2 more reviewers

@vudaltsovvudaltsovvudaltsov approved these changes

@seriquynhseriquynhseriquynh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tobion@fabpot@vudaltsov@seriquynh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp