Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] make the bridge act as a polyfill for newest PHPUnit features#32922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromnicolas-grekas:pub-changelog
Aug 5, 2019

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedAug 4, 2019
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

It's been quite a tunnel these days with@jderusse but here we are: the phpunit-bridge is now a fully working polyfill for newest PHPUnit features. All related PRs have been merged as "minor" but they are now ready for prime time, hence this PR that I'd like to be merged as "feature", to make it part of the changelog of Symfony 4.4.

As of version 4.4, thesimple-phpunit script will run an augmented version of PHPUnit, that will provide the newest assertions of PHPUnit 8 even if you happen to be running PHPUnit 4.8+ (because you still need to test on PHP 5.5, as Symfony does.)

The bridge currently provides polyfills for the methods that are needed to make our tests pass on PHP 7.4 with no deprecations:

More polyfills might be added if you need them. PRs welcome as usual.

As of#32882, when theSYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT is set to1,simple-phpunit will alsopatch the source of PHPUnit 8 to remove thevoid return-type onsetUp*/tearDown*. This is required when the same codebase must be tested against PHP 5.5 up to 7.4+ (as does our branch 3.4). For codebases that don't want or can't run their tests withsimple-phpunit but want to run their PHP 5.5 tests with PHPUnit 8, the bridge provides a newSetUpTearDownTrait that allows asmooth transition to it.

Along the path, we also created a new tool for our CI: it's now possible to submit a new polyfill on the current feature-branch (4.4 these days) and test it with a PR on another branch. See#32887 for the patch.

All these new features have been added to achieve PHP 7.4 support on branch 3.4. There are still many deprecations that need to be fixed, all tracked in#32844. It should be a pretty nice list of "good first issues". Thank you@luispabon,@tweichart,@Alexander1000 BTW.

A big specific thank you to@jderusse for the help!

Let's rock PHP 7.4, can't wait for your PRs, see you on#32844 :)

romainnorberg reacted with thumbs up emojiDavertMik, jderusse, mykiwi, greg0ire, dmaicher, mickaelandrieu, rvanlaak, Simperfit, romainnorberg, yceruto, and 3 more reacted with hooray emojiteohhanhui reacted with confused emoji
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit271211b intosymfony:4.4Aug 5, 2019
fabpot added a commit that referenced this pull requestAug 5, 2019
…newest PHPUnit features (nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] make the bridge act as a polyfill for newest PHPUnit features| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -It's been quite a tunnel these days with@jderusse but here we are: the phpunit-bridge is now a fully working polyfill for newest PHPUnit features. All related PRs have been merged as "minor" but they are now ready for prime time, hence this PR that I'd like to be merged as "feature", to make it part of the changelog of Symfony 4.4.As of version 4.4, the `simple-phpunit` script will run an augmented version of PHPUnit, that will provide the newest assertions of PHPUnit 8 even if you happen to be running PHPUnit 4.8+ (because you still need to test on PHP 5.5, as Symfony does.)The bridge currently provides polyfills for the methods that are needed to make our tests pass on PHP 7.4 with no deprecations:-#32878#32907 `assertString(Not)ContainsString(IgnoringCase)`, `assertEqualsWithDelta` and `assert(Not)ContainsEquals`-#32875 `expectException*`, which replace `@expectedException*` annotations-#32846 `assertIs*`, which replace `assertInternalType`-#32865 `create(Partial)Mock`-#32931 `assert(File|Directory)(Not)(Exists|IsReadable|IsWritable)`More polyfills might be added if you need them. PRs welcome as usual.As of#32882, when the `SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT` is set to `1`, `simple-phpunit` will also [patch](https://github.com/symfony/symfony/blob/884669b83b131df8c3c41ad6517abe8cff7903b0/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php#L149) the source of PHPUnit 8 to remove the `void` return-type on `setUp*`/`tearDown*`. This is required when the same codebase must be tested against PHP 5.5 up to 7.4+ (as does our branch 3.4). For codebases that don't want or can't run their tests with `simple-phpunit` but want to run their PHP 5.5 tests with PHPUnit 8, the bridge provides a new `SetUpTearDownTrait` that allows a [smooth transition](https://github.com/php-cache/integration-tests/blob/c59a4d2dec1e462e5f5646e5fe102f403d6b8903/src/CachePoolTest.php#L21) to it.Along the path, we also created a new tool for our CI: it's now possible to submit a new polyfill on the current feature-branch (4.4 these days) and test it with a PR on another branch. See#32887 for the patch.All these new features have been added to achieve PHP 7.4 support on branch 3.4. There are still many deprecations that need to be fixed, all tracked in#32844. It should be a pretty nice list of "good first issues". Thank you@luispabon,@tweichart,@Alexander1000 BTW.A big specific thank you to@jderusse for the help!Let's rock PHP 7.4, can't wait for your PRs, see you on#32844 :)Commits-------271211b [PhpUnitBridge] make the bridge act as a polyfill for newest PHPUnit features
@nicolas-grekasnicolas-grekas deleted the pub-changelog branchAugust 5, 2019 06:45
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@greg0iregreg0iregreg0ire left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@fabpot@greg0ire@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp