Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Order alpha2 to alpha3 mapping + phpdoc fixes#32919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(but should be rebased on top of#32918 once merge, also please confirm that none of the docblock changes apply to 3.4)
ro0NL commentedAug 4, 2019
confirmed none of the docblocks apply to 3.4 :) the new static api is introduced in 4.3, i'll let the legacy api in 3.4 rest in peace. |
fabpot commentedAug 5, 2019
Thank you@ro0NL. |
This PR was merged into the 4.3 branch.Discussion----------[Intl] Order alpha2 to alpha3 mapping + phpdoc fixes| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#32676 (review)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->includes#32918Commits-------867e3de [Intl] Order alpha2 to alpha3 mapping + phpdoc fixes
includes#32918