Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PHPUnit Bridge] Avoid registering listener twice#32903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromgreg0ire:carry-31649
Sep 2, 2019

Conversation

@greg0ire
Copy link
Contributor

The listener can be registered via configuration by the user. In that
case, we do not want to add it again to the list of listeners.
Closes#31649

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

@greg0iregreg0ireforce-pushed thecarry-31649 branch 2 times, most recently from0921e34 to5936735CompareAugust 3, 2019 12:47
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneAug 3, 2019
@OskarStark
Copy link
Contributor

@xabbuh can we merge this one?

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fabpot
Copy link
Member

/cc@nicolas-grekas

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(just minor CS nitpicking)

The bridge listener can be registered via configuration by the user. In thatcase, we do not want to add it again to the list of listeners.Closessymfony#31649
@greg0ire
Copy link
ContributorAuthor

just minor CS nitpicking

addressed :)

@nicolas-grekas
Copy link
Member

/cc@alexpott FYI

@nicolas-grekas
Copy link
Member

Thank you@greg0ire.

greg0ire reacted with heart emoji

nicolas-grekas added a commit that referenced this pull requestSep 2, 2019
This PR was merged into the 3.4 branch.Discussion----------[PHPUnit Bridge] Avoid registering listener twiceThe listener can be registered via configuration by the user. In thatcase, we do not want to add it again to the list of listeners.Closes#31649| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aCommits-------b190536 Check phpunit configuration for listeners
@nicolas-grekasnicolas-grekas merged commitb190536 intosymfony:3.4Sep 2, 2019
@greg0iregreg0ire deleted the carry-31649 branchSeptember 2, 2019 20:07
@fabpotfabpot mentioned this pull requestOct 7, 2019
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

9 participants

@greg0ire@OskarStark@fabpot@nicolas-grekas@jderusse@xabbuh@Simperfit@carsonbot@alexpott
[8]ページ先頭
©2009-2025 Movatter.jp