Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adopt@PHPUnit55Migration:risky rule of php-cs-fixer#32884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

We might have to polyfillcreatePartialMock before merging this one.

'@Symfony:risky' =>true,
'@PHPUnit48Migration:risky' =>true,
'php_unit_no_expectation_annotation' =>false,// part of `PHPUnitXYMigration:risky` ruleset, to be enabled when PHPUnit 4.x support will be dropped, as we don't want to rewrite exceptions handling twice
'@PHPUnit55Migration:risky' =>true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can bePHPUnit75Migration:risky

php_unit_dedicate_assert should be configured to withtarget = 3.5 as all methods are not (yet) pollyfiled (ieassertDirectoryExist) in phpunit 4

@nicolas-grekas
Copy link
MemberAuthor

Closing in favor of#32885

@nicolas-grekasnicolas-grekas deleted the cs-phpunit55 branchAugust 2, 2019 14:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@jderusse@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp