Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Replace calls to setExpectedException by Pollyfill#32872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromjderusse:compat-phpunit9-setExpectedExceptionAug 1, 2019
Merged
[PhpUnitBridge] Replace calls to setExpectedException by Pollyfill#32872
nicolas-grekas merged 1 commit intosymfony:3.4fromjderusse:compat-phpunit9-setExpectedExceptionAug 1, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
OskarStark approved these changesAug 1, 2019
87220e4 to5df9fefCompare5df9fef to3074265Compare3074265 to41c02d7Comparemaxhelias approved these changesAug 1, 2019
Member
nicolas-grekas commentedAug 1, 2019
Thank you@jderusse. |
nicolas-grekas added a commit that referenced this pull requestAug 1, 2019
…usse)This PR was merged into the 3.4 branch.Discussion----------Replace calls to setExpectedException by Pollyfill| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | need#32869 to be merged| Fixed tickets |#32844| License | MIT| Doc PR | NAPhpUnit method `setExceptionException` has been deprecated seens 5.7. This PR replace theme by `exceptException` provide by the pollyfill.Commits-------41c02d7 Replace calls to setExpectedException by Pollyfill
| 'InvalidArgumentException', | ||
| 'You cannot refresh a user from the EntityUserProvider that does not contain an identifier. The user object has to be serialized with its own identifier mapped by Doctrine' | ||
| ); | ||
| $this->expectException('InvalidArgumentException'); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we should use::class constant wherever we update this. best opportunity yet.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhpUnit method
setExceptionExceptionhas been deprecated seens 5.7. This PR replace theme byexceptExceptionprovide by the pollyfill.