Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

#32853 Check if $this->parameters is array.#32870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromABGEO:32853-undefined-env-issue
Aug 3, 2019
Merged

#32853 Check if $this->parameters is array.#32870

nicolas-grekas merged 1 commit intosymfony:3.4fromABGEO:32853-undefined-env-issue
Aug 3, 2019

Conversation

@ABGEO
Copy link
Contributor

@ABGEOABGEO commentedAug 1, 2019•
edited
Loading

QA
Branch?4.3
Bug fix?yes
New feature?no
Tests pass?yes
Fixed tickets#32853
LicenseMIT

@nicolas-grekas
Copy link
Member

Would it work if we initializer the property to the empty array when it is declared instead?
The fix should target branch 3.4 btw, thanks.

@ABGEO
Copy link
ContributorAuthor

ABGEO commentedAug 3, 2019•
edited
Loading

Would it work if we initializer the property to the empty array when it is declared instead?
The fix should target branch 3.4 btw, thanks.

@nicolas-grekas Yes, it will. If the array is empty, it will return false.

@nicolas-grekas
Copy link
Member

Great, can you update the patch then please?

@nicolas-grekas
Copy link
Member

I mean: change the patch to initialize the property, and revert the current changes.

@ABGEO
Copy link
ContributorAuthor

@nicolas-grekas Done and it works.

@nicolas-grekasnicolas-grekas changed the base branch from4.3 to3.4August 3, 2019 18:12
@nicolas-grekas
Copy link
Member

Thank you @ABGEO07.

ABGEO reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit7cf9ed6 intosymfony:3.4Aug 3, 2019
nicolas-grekas added a commit that referenced this pull requestAug 3, 2019
This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes#32870).Discussion----------| Q             | A| ------------- | ---| Branch?     | 4.3| Bug fix?      | yes| New feature?  | no| Tests pass?   | yes| Fixed tickets |#32853| License       | MITCommits-------7cf9ed6#32853 Check if $this->parameters is array.
@ABGEOABGEO deleted the 32853-undefined-env-issue branchAugust 3, 2019 18:26
This was referencedAug 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ABGEO@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp