Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Add polyfill for expectException* methods#32869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:masterfromjderusse:polyfill-phpunit-setexceptionAug 1, 2019
Merged
[PhpUnitBridge] Add polyfill for expectException* methods#32869
nicolas-grekas merged 1 commit intosymfony:masterfromjderusse:polyfill-phpunit-setexceptionAug 1, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
951f008 todc7a2d7CompareUh oh!
There was an error while loading.Please reload this page.
Contributor
Tobion commentedAug 1, 2019
Why is the PR for master? |
Member
nicolas-grekas commentedAug 1, 2019
The reason is that the master version of the bridge is used to test all branches, so merging here first will unlock testing the PR on 3.4 (and we will merge this patch also on 3.4 then) |
dc7a2d7 tod8c384bComparenicolas-grekas approved these changesAug 1, 2019
| parent::setExpectedExceptionRegExp($exceptionName,$exceptionMessageRegExp,$exceptionCode); | ||
| } | ||
| } | ||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this extra line is too much
maxhelias approved these changesAug 1, 2019
d8c384b toc7a8ce5CompareMember
nicolas-grekas commentedAug 1, 2019
Thank you@jderusse. |
nicolas-grekas added a commit that referenced this pull requestAug 1, 2019
…s (jderusse)This PR was merged into the 5.0-dev branch.Discussion----------[PhpUnitBridge] Add polyfill for expectException* methods| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | NAthis PR provides a polyfill for methods `setException`, `setExceptionMessage`, `setExceptionMessageRegExp` and `setExceptionCode`Commits-------c7a8ce5 [Bridge/PhpUnit] Add polyfill for expectException*
nicolas-grekas added a commit that referenced this pull requestAug 1, 2019
…usse)This PR was merged into the 3.4 branch.Discussion----------Replace calls to setExpectedException by Pollyfill| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | need#32869 to be merged| Fixed tickets |#32844| License | MIT| Doc PR | NAPhpUnit method `setExceptionException` has been deprecated seens 5.7. This PR replace theme by `exceptException` provide by the pollyfill.Commits-------41c02d7 Replace calls to setExpectedException by Pollyfill
nicolas-grekas added a commit that referenced this pull requestAug 3, 2019
…tring*() (Tobias Weichart)This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] added polyfill for assertStringContainsString*()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | -this PR provides a polyfill for methods assertStringContainsString and assertStringContainsStringIgnoringCase in preparation for the PHPUnit 9 deprecations.PR follows the pattern of [this PR](#32869), hence the PR to masterCommits-------1602441 [PhpUnitBridge] added polyfill for assertStringContainsString*()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR provides a polyfill for methods
setException,setExceptionMessage,setExceptionMessageRegExpandsetExceptionCode