Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Skip tests that fatal-error on PHP 7.4 because of missing parent classes#32864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d861b33 toc2c7ba8Comparenicolas-grekas added a commit that referenced this pull requestAug 1, 2019
…g parent classes (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------Skip tests that fatal-error on PHP 7.4 because of missing parent classes| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32844| License | MIT| Doc PR | -See#32395 andhttps://bugs.php.net/78351 for more background.This skips the affected tests with a warning, which means tests won't pass so we won't forget about them.Commits-------c2c7ba8 Skip tests that fatal-error on PHP 7.4 because of missing parent classes
23 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See#32395 andhttps://bugs.php.net/78351 for more background.
This skips the affected tests with a warning, which means tests won't pass so we won't forget about them.