NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[PhpUnitBridge] Fix deprecation assertInternalType - 4.3#32856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

jderusse wants to merge1 commit intosymfony:4.3fromjderusse:4.3

Closed

[PhpUnitBridge] Fix deprecation assertInternalType - 4.3#32856

jderusse wants to merge1 commit intosymfony:4.3fromjderusse:4.3

Conversation

Copy link

Member

jderusse commentedAug 1, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32844
License	MIT
Doc PR	NA

This PR fixes PhpUnit deprecation :

assertInternalType() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertIsArray(), assertIsBool(), assertIsFloat(), assertIsInt(), assertIsNumeric(), assertIsObject(), assertIsResource(), assertIsString(), assertIsScalar(), assertIsCallable(), or assertIsIterable() instead

follow#32846 for 4.3 branch