Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Ensure signatures for setUp|tearDown|setUpAfterClass|tearDownAfterClass methods in tests are compatible with phpunit 8.2#32854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromluispabon:4.3/phpunit82-void-setup-teardownAug 1, 2019
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedAug 1, 2019
Thanks :) |
ContributorAuthor
luispabon commentedAug 1, 2019
Done. |
nicolas-grekas approved these changesAug 1, 2019
…ss methods in tests are compatible with phpunit 8.2
48deeaf to97bcb5dCompareMember
nicolas-grekas commentedAug 1, 2019
Thank you@luispabon. |
nicolas-grekas added a commit that referenced this pull requestAug 1, 2019
…rDownAfterClass methods in tests are compatible with phpunit 8.2 (luispabon)This PR was squashed before being merged into the 4.3 branch (closes#32854).Discussion----------Ensure signatures for setUp|tearDown|setUpAfterClass|tearDownAfterClass methods in tests are compatible with phpunit 8.2| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | no| Fixed tickets |#32844| License | MIT| Doc PR | n/aPlease bear with me as this is my first pr to symfony. Branched off 4.3 as requested here:#32844Tests currently do not pass due to:```PHP Fatal error: Declaration of Symfony\Bridge\Monolog\Logger::reset() must be compatible with Monolog\Logger::reset(): void in /home/luis/Projects/symfony/src/Symfony/Bridge/Monolog/Logger.php on line 23```Commits-------97bcb5d Ensure signatures for setUp|tearDown|setUpAfterClass|tearDownAfterClass methods in tests are compatible with phpunit 8.2
ContributorAuthor
luispabon commentedAug 1, 2019
👍 |
23 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please bear with me as this is my first pr to symfony. Branched off 4.3 as requested here:#32844
Tests currently do not pass due to: