Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Add assertIsX methods in ForwardCompatTestTrait#32848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jderusse commentedAug 1, 2019
fabbot want to remove |
| * | ||
| * @return void | ||
| */ | ||
| publicstaticfunctionassertIsArray($actual,$message ='') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| publicstaticfunction assertIsArray($actual,$message ='') | |
| publicstaticfunction assertIsArray($actual,string$message ='') |
should be no problem, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not compatible with php 5. The bridge don't use the same version of PHP.
symfony/src/Symfony/Bridge/PhpUnit/composer.json
Lines 18 to 22 inf830226
| "require": { | |
| "php":">=5.5.9 EVEN ON LATEST SYMFONY VERSIONS TO ALLOW USING", | |
| "php":"THIS BRIDGE WHEN TESTING LOWEST SYMFONY VERSIONS.", | |
| "php":">=5.5.9" | |
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
jderusse commentedAug 1, 2019
closing this PR as#32846 (already merged) contains the code |
PhpUnit 8 deprecates the method
assertInternalTypein favor ofassertIsX. This PR add the polyfill methodsassertIsXin theForwardCompatTestTraitForV5. It'sq a requirement to update tests in order to be compatible with both PhpUnit 5 and 8note: this PR split the PR#32846 to provides methods in the branch
masterin order to fix the test suite for#32846