NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Make tests support phpunit 8#32842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:3.4fromnicolas-grekas:phpunit8

Jul 31, 2019

Merged

Make tests support phpunit 8#32842

nicolas-grekas merged 1 commit intosymfony:3.4fromnicolas-grekas:phpunit8

Jul 31, 2019

Conversation

Copy link

Member

nicolas-grekas commentedJul 31, 2019•
edited
Loading

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Havingvoid on setUp/tearDown isreally painful /cc@sebastianbergmann FYI

This works around the issue by adding a new trait to the phpunit-bridge :ForwardCompatTestTrait.
Another reason why the bridge is so useful...

With this change, we should have the same codebase be able to run under phpunit 4.8 (used with PHP5.5) up to phpunit 8.2 (used with PHP7.4).

🤞 🤕

One more step towards PHP 7.4 support.

nicolas-grekas added this to the3.4 milestone

Jul 31, 2019

nicolas-grekas requested review fromlyrixx andxabbuh ascode owners

July 31, 2019 19:28

carsonbot added Status: Needs Review Bug labels

Jul 31, 2019

nicolas-grekas force-pushed thephpunit8 branch 2 times, most recently from88e284d to144abebCompare

July 31, 2019 21:29

Make tests support phpunit 8

81af97f

nicolas-grekas force-pushed thephpunit8 branch from144abeb to81af97fCompare

July 31, 2019 21:58

nicolas-grekas added a commit that referenced this pull request

Jul 31, 2019

minor#32842Make tests support phpunit 8 (nicolas-grekas)

5fa9ed4

This PR was merged into the 3.4 branch.Discussion----------Make tests support phpunit 8| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Having `void` on setUp/tearDown is **really** painful /cc@sebastianbergmann FYIThis works around the issue by adding a new trait to the phpunit-bridge: `SetUpTearDownTrait`.Another reason why the bridge is so useful...With this change, we should have the same codebase be able to run under phpunit 4.8 (used with PHP5.5) up to phpunit 8.2 (used with PHP7.4).:crossed_fingers: :face_with_head_bandage:One more step towards PHP 7.4 support.Commits-------81af97f Make tests support phpunit 8

nicolas-grekas merged commit81af97f intosymfony:3.4

Jul 31, 2019

nicolas-grekas deleted the phpunit8 branch

July 31, 2019 22:40

nicolas-grekas mentioned this pull request

Jul 31, 2019

PHP 7.4 + PHPUnit 8.2 support#32844

Closed

23 tasks

Copy link

Contributor

Tobion commentedAug 1, 2019

This looks like a huge source of conflicts. Are we sure we want to introduce that? The alternatives would be to not support phpunit 8 or only do these changes in 4.4 and up.

Copy link

MemberAuthor

nicolas-grekas commentedAug 1, 2019•
edited
Loading

This is merged up to master now so that conflicts are resolved once for all. We have to support phpunit 8 because that's the only way to PHP 7.4, which we want to support on branch 3.4...