NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Preserve the case of headers when sending them#32823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.3fromnicolas-grekas:hc-ucwords

Jul 31, 2019

Merged

[HttpClient] Preserve the case of headers when sending them#32823

nicolas-grekas merged 1 commit intosymfony:4.3fromnicolas-grekas:hc-ucwords

Jul 31, 2019

Conversation

Copy link

Member

nicolas-grekas commentedJul 30, 2019•
edited
Loading

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32819
License	MIT
Doc PR	-

Some hosts are case sensitive, let's present headers in the submitted form.

nicolas-grekas added this to the4.3 milestone

Jul 30, 2019

carsonbot added Status: Needs Review HttpClient Bug labels

Jul 30, 2019

nicolas-grekas mentioned this pull request

Jul 30, 2019

[HttpClient] Headers are lowercased#32819

Closed

Copy link

Member

fabpot commentedJul 31, 2019

What aboutETag?

Copy link

Member

javiereguiluz commentedJul 31, 2019

@nicolas-grekas as you said here#32819 (comment)

In HTTP 1, headers should be lowercase(but some APIs don't respect that)
In HTTP/2, headers can only be lowercase

So, could we leave headers as-is when using HTTP 1 (no strtolower, no ucwords, no changes whatsoever) and just applystrtolower() unconditionally when using HTTP/2? Thanks.

Copy link

MemberAuthor

nicolas-grekas commentedJul 31, 2019

Got it, see also comments on the linked issue.

Copy link

MemberAuthor

nicolas-grekas commentedJul 31, 2019

So, could we leave headers as-is when using HTTP 1 (no strtolower, no ucwords, no changes whatsoever) and just apply strtolower() unconditionally when using HTTP/2? Thanks.

That is not possible, because the protocol can be decided automatically.
The only sensible way is to preserve the input case.
That will break normalization, but since this is internal concern, there should be ways around.

nicolas-grekas changed the title~~[HttpClient] use ucwords() on header names before sending them~~[HttpClient] Preserve the case of headers when sending them

Jul 31, 2019

nicolas-grekas force-pushed thehc-ucwords branch fromc0ef6e6 to3829d87Compare

July 31, 2019 11:24

Copy link

MemberAuthor

nicolas-grekas commentedJul 31, 2019

PR updated, ready.

javiereguiluz approved these changes

Jul 31, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 31, 2019

[HttpClient] Preserve the case of headers when sending them

9ac85d5

nicolas-grekas force-pushed thehc-ucwords branch from3829d87 to9ac85d5Compare

July 31, 2019 11:44

nicolas-grekas merged commit9ac85d5 intosymfony:4.3

Jul 31, 2019

nicolas-grekas added a commit that referenced this pull request

Jul 31, 2019

bug#32823[HttpClient] Preserve the case of headers when sending the…

9ac3552

…m (nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] Preserve the case of headers when sending them| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32819| License       | MIT| Doc PR        | -Some hosts are case sensitive, let's present headers in the submitted form.Commits-------9ac85d5 [HttpClient] Preserve the case of headers when sending them

nicolas-grekas deleted the hc-ucwords branch

July 31, 2019 15:52